feat: display estimated effective volume during buy (#479)#485
Open
LevilkTheReal wants to merge 3 commits intoethersphere:masterfrom
Open
feat: display estimated effective volume during buy (#479)#485LevilkTheReal wants to merge 3 commits intoethersphere:masterfrom
LevilkTheReal wants to merge 3 commits intoethersphere:masterfrom
Conversation
Collaborator
|
@LevilkTheReal For depths <= 21, I would maybe remove the message: It looks like a bug. Instead I would print a human friendly message, something like "effective volume is likely to be smaller than estimated capacity". What do you think? |
Author
Sounds good! What do you think about the fix? Should I just write that message or can I keep the key for the message? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #479
Solution:
@Cafe137 FYI
I could not run the tests. I am getting this error. Any idea?
(I've extended the tests with this line tho:
expect(consoleMessages[2]).toBe('Estimated effective volume: 41.17 GB'))Another thing. The Storage class is not that precise. For instance, it converts the incoming effective bytes to 41.17 GB which should be 44.21 GB.
Also, there are different converters/repos. Is it worth creating a shared one?